Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved styling #25

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improved styling #25

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 23, 2021

Improved styling, I was thinking to add a whole css framework but I will not. With the current design of this website, it's not possible to create a perfect website, if I add framework, I had to start from scratch. So I will keep adding little stylings.

@vercel
Copy link

vercel bot commented Apr 23, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/umanghome/twitter-search-covid19/23Nf6MAdo9E2QhmA1yExDpTVLQfc
✅ Preview: https://twitter-search-covid19-git-fork-backdropfilter-main-umanghome.vercel.app

@umanghome
Copy link
Owner

umanghome commented Apr 24, 2021

I like the link and blue button changes, but most other things can be kept as-in. Reasons:

  1. People aren't able to figure out that you can search for any city. That's why the input for city name is bigger than other input.
  2. Please do not remove outlines from anything.
  3. Extra whitespace looks pretty, but it reduces what the user can see on their first visit to the page. 90+% traffic is from mobile devices.
  4. This^ also means that things that don't need to be huge shouldn't be huge, like the image.

@ghost
Copy link
Author

ghost commented Apr 24, 2021

Okay so I have to improve then design without increasing space,
But what's the problem with outline?
I can add a framework which is not much heavy and easy to use but that will require whole redesign.
I can improve the UI, just send me any example. We have to make it user friendly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants